Conversation
We implemented this as part of the Welsh translations work, so this TODO comment can be removed
DavidBiddle
changed the title
TODO: comments to cardsTODO: comments
| <% end %> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Something's gone a bit wrong with the indenting here? Not necessarily against reindenting this file, but I think the last closing </div> should have zero indent to match the opening tag.
| <%= f.govuk_submit t("save_and_continue") %> | ||
| <% end %> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Again, the indentation here seems off?
DavidBiddle
force-pushed
the
assign-todo-comments-to-cards
branch
from
e2a8d8c to
30ed588
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2689.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
2 participants
What problem does this pull request solve?
Trello card: https://trello.com/c/hK0527GN/219-review-todo-comments-and-make-product-cards-for-any-that-are-still-relevant
As part of firebreak work we've reviewed the outstanding TODO: comments in this repo and made tech debt cards for them.
This PR adds references to those tech debt cards in the codebase, so that anyone tackling the TODO tasks in future can easily check the card for additional context.
It also removes a TODO comment for something we've already implemented.
Things to consider when reviewing